This repository was archived by the owner on May 15, 2023. It is now read-only.
Raise specific exception for bad auth.#155
Open
dHannasch wants to merge 5 commits intojasonrollins:masterfrom
Open
Raise specific exception for bad auth.#155dHannasch wants to merge 5 commits intojasonrollins:masterfrom
dHannasch wants to merge 5 commits intojasonrollins:masterfrom
Conversation
Owner
|
I see what you're doing there. That looks good. I think we can just keep it in the getuser function since we know it will get called on initialization. You don't need to replace the post() function, its a wrapper for self._session.post(). Can you confirm that this gives the appropriate error on SharePoint 2016? |
Author
|
I had to replace the post() function because the wrapper immediately raises an exception on a 404. In this case, to confirm that it's actually a permission error (rather than the URL not being found, as you would normally interpret a 404), we want to first check that posting to the URL normally receives a 200 OK. With this merged into the gitlab-ci-yml branch, this is now the error that gets raised when I try to run the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm picturing something like this to give a more informative error message in the case of bad auth. Thoughts?