Skip to content

Conversation

jasonyuezhang
Copy link
Owner

count_scores actually returns null, so checking for 0 doesn't work.


Copied from getsentry#100916
Original PR: getsentry#100916

Copy link

Fix Web Vitals Transaction Table No Value Display for Missing Data

This pull request corrects the handling of missing Web Vitals data in the pagePerformanceTable.tsx component. Previously, the table would only display a no-value indicator if count_scores equaled 0, but since count_scores may return null, missing or null data was not properly rendered. The conditional checks are now updated to handle null or undefined by using a truthy check instead of equality to zero.

Key Changes

• Updated conditional checks in renderBodyCell for Web Vitals-derived columns to use !countWebVital instead of countWebVital === 0.
• Ensured that rows with missing or null Web Vitals data display the NoValue indicator as intended.

Affected Areas

static/app/views/insights/browser/webVitals/components/tables/pagePerformanceTable.tsx
• Web Vitals transaction table rendering logic

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants