Skip to content

Conversation

jasonyuezhang
Copy link
Owner

Not sure why these definitions were in the spans folder. Moving it out to the logs folder.


Copied from getsentry#100922
Original PR: getsentry#100922

Not sure why these definitions were in the spans folder. Moving it out to the
logs folder.
Copy link

Refactor: Move log aggregate definitions to dedicated file

This pull request refactors the organization of log aggregate definitions within the codebase. The primary change is moving the LOG_AGGREGATE_DEFINITIONS from src/sentry/search/eap/spans/aggregates.py to a new dedicated file at src/sentry/search/eap/ourlogs/aggregates.py. The relevant imports in src/sentry/search/eap/ourlogs/definitions.py are updated to use the new location, and the definitions are removed from the original spans aggregates module. No changes are made to the logic or contents of the aggregate definitions themselves-this is a structural/code organization change only.

Key Changes

• Moved LOG_AGGREGATE_DEFINITIONS from src/sentry/search/eap/spans/aggregates.py to src/sentry/search/eap/ourlogs/aggregates.py
• Updated import in src/sentry/search/eap/ourlogs/definitions.py to refer to the new location
• Removed the log aggregate definitions from src/sentry/search/eap/spans/aggregates.py

Affected Areas

src/sentry/search/eap/ourlogs/aggregates.py
src/sentry/search/eap/spans/aggregates.py
src/sentry/search/eap/ourlogs/definitions.py

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants