You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Usage of deprecatedRouteProps from VitalDetail View
This pull request removes all instances of deprecatedRouteProps from the VitalDetail view under sentry/views/performance/vitalDetail. The refactor transitions the view components and associated tests to modern routing and context patterns, eliminates legacy router usage, and introduces hooks-based context retrieval for organization, projects, and related data. Test utilities and props are updated to match the new hooks approach and route initialization logic, aligning the code with frontend modernization efforts.
Key Changes
• Eliminated usage of deprecatedRouteProps in the main VitalDetail route definition within static/app/routes.tsx.
• Refactored static/app/views/performance/vitalDetail/index.tsx and vitalDetailContent.tsx to use hooks such as useOrganization, useProjects, usePageFilters, and useLocation instead of props or HOCs.
• Removed all usage of InjectedRouter, withOrganization, withProjects, and related HOCs in favor of hooks.
• Updated tests in index.spec.tsx to use initialRouterConfig and hooks-based context, removing dependencies on the legacy router and deprecated mocks.
• All navigation logic switched to use the navigate hook instead of browserHistory or router.push.
• Removed prop drilling and outdated type definitions related to the legacy router and project selection.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates usage of
deprecatedRoutePropsforVitalDetail-sentry/views/performance/vitalDetail.https://www.notion.so/sentry/Frontend-TSC-Project-Remove-all-uses-of-deprecatedRouteProps-true-26a8b10e4b5d8015a6a2dd14f9d41dd7
Copied from getsentry#100923
Original PR: getsentry#100923