-
Notifications
You must be signed in to change notification settings - Fork 0
fix(seer): Smooth summary anmiation, no initial animation #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
disable animation when the drawer is opening and remove chunky-ness when collapsing
Improve Group Summary Animation Using Framer Motion This pull request refines the expand/collapse animation for the Key Changes• Replaced previous CSS Affected Areas• This summary was automatically generated by @propel-code-bot |
transition={testableTransition({ | ||
type: 'spring', | ||
damping: 50, | ||
stiffness: 600, | ||
bounce: 0, | ||
visualDuration: 0.4, | ||
})} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[PerformanceOptimization]
The spring animation configuration has very high stiffness (600) and damping (50) which could cause performance issues on slower devices, especially when multiple drawers are animated simultaneously. The high stiffness combined with bounce: 0
might also create jarring motion.
Consider more moderate values for better performance and smoother feel:
Suggested Change
transition={testableTransition({ | |
type: 'spring', | |
damping: 50, | |
stiffness: 600, | |
bounce: 0, | |
visualDuration: 0.4, | |
})} | |
transition={testableTransition({ | |
type: 'spring', | |
damping: 25, | |
stiffness: 300, | |
bounce: 0, | |
visualDuration: 0.3, | |
})} |
⚡ Committable suggestion
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Context for Agents
[**PerformanceOptimization**]
The spring animation configuration has very high stiffness (600) and damping (50) which could cause performance issues on slower devices, especially when multiple drawers are animated simultaneously. The high stiffness combined with `bounce: 0` might also create jarring motion.
Consider more moderate values for better performance and smoother feel:
<details>
<summary>Suggested Change</summary>
```suggestion
transition={testableTransition({
type: 'spring',
damping: 25,
stiffness: 300,
bounce: 0,
visualDuration: 0.3,
})}
```
⚡ **Committable suggestion**
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
</details>
File: static/app/components/group/groupSummary.tsx
Line: 301
uses framer motion to disable animation when the drawer is opening and remove chunky-ness when collapsing
before
CleanShot.2025-10-03.at.14.32.09.mp4
after
CleanShot.2025-10-03.at.14.32.53.mp4
Copied from getsentry#100924
Original PR: getsentry#100924