chore(eco): async deletions for sentry app installations #27
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| except RequestException as exc: | ||
| sentry_sdk.capture_exception(exc) | ||
| deletions.exec_sync(sentry_app_installation) | ||
| ScheduledDeletion.schedule(sentry_app_installation, days=0, actor=request.user) |
There was a problem hiding this comment.
Bug: Audit Log Missing Transaction ID
The audit log for Sentry App Installation deletion is created immediately after scheduling the asynchronous deletion, without linking to the ScheduledDeletion object via a transaction_id. This can result in an inconsistent audit trail, as the log may show an uninstalled status even if the deletion later fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a sentry app installation should use async deletions.
The tests for async sentry app deletion cover the below case:
https://github.com/getsentry/sentry/blob/e49b651754eaad16f271ce8ddf7e97a457f64cf3/src/sentry/deletions/defaults/sentry_app.py#L14
Required for getsentry#100813
Copied from getsentry#100930
Original PR: getsentry#100930