Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from __future__ import annotations

from drf_spectacular.utils import OpenApiParameter, extend_schema
from rest_framework import status
from rest_framework.exceptions import ParseError, ValidationError
from rest_framework.request import Request
from rest_framework.response import Response
Expand Down Expand Up @@ -128,10 +127,8 @@ def get(self, request: Request, organization: Organization) -> Response:
)
)
if not target_group:
return Response(
{"detail": "Group not found. Could not query open periods."},
status=status.HTTP_404_NOT_FOUND,
)
return self.paginate(request=request, queryset=[])

limit = None
per_page = request.GET.get("per_page")
if per_page:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from datetime import timedelta

from django.utils import timezone
from rest_framework import status

from sentry.incidents.grouptype import MetricIssue
from sentry.models.activity import Activity
Expand Down Expand Up @@ -52,12 +51,12 @@ def get_url_args(self):
def test_no_group_link(self) -> None:
# Create a new detector with no linked group
detector = self.create_detector()
resp = self.get_error_response(
resp = self.get_success_response(
self.organization.slug,
qs_params={"detectorId": detector.id},
status_code=status.HTTP_404_NOT_FOUND,
status_code=200,
)
assert resp.data["detail"] == "Group not found. Could not query open periods."
assert resp.data == []

def test_open_period_linked_to_group(self) -> None:
response = self.get_success_response(
Expand Down