-
Notifications
You must be signed in to change notification settings - Fork 0
Rc/update member invite copy #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Updated the member invite email template to enhance messaging and add a welcome note.
Updated the member invite email template to enhance messaging and include new features.
fixed the html file so the signature would render properly and updated markdown link syntax in the text file
Revise Member Invite Email Content and Layout This pull request updates the content and layout of the member invite email templates in both HTML and plaintext formats. The changes modernize and personalize the email copy, introduce a section highlighting the new 'Seer' AI debugging agent feature, and provide a more engaging and security-conscious invitation message for new members. Key Changes• Replaced existing member invite copy in Affected Areas• This summary was automatically generated by @propel-code-bot |
{% block main %} | ||
<h3>You've been invited to Sentry</h3> | ||
<p>Your teammates at <strong>{{ organization.name|sanitize_periods }}</strong> are using Sentry to track and debug software errors.</p> | ||
<p>He there,</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[BestPractice]
Typo in greeting: "He there," should be "Hey there," to match the plain text version and standard greeting format.
<p>He there,</p> | |
<p>Hey there,</p> |
⚡ Committable suggestion
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Context for Agents
[**BestPractice**]
Typo in greeting: "He there," should be "Hey there," to match the plain text version and standard greeting format.
```suggestion
<p>Hey there,</p>
```
⚡ **Committable suggestion**
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
File: src/sentry/templates/sentry/emails/member-invite.html
Line: 7
<h3>You've been invited to Sentry</h3> | ||
<p>Your teammates at <strong>{{ organization.name|sanitize_periods }}</strong> are using Sentry to track and debug software errors.</p> | ||
<p>He there,</p> | ||
<p>Your teammates at <strong>{{ organization.name }}</strong> are using Sentry to catch errors, improve latency issues, and keep their (and maybe your) code from catching fire. 🔥</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[BestPractice]
Template variable filtering inconsistency: The original code used {{ organization.name|sanitize_periods }}
but the new code uses {{ organization.name }}
without the filter. This could introduce security issues or rendering problems if organization names contain periods that need sanitization.
<p>Your teammates at <strong>{{ organization.name }}</strong> are using Sentry to catch errors, improve latency issues, and keep their (and maybe your) code from catching fire. 🔥</p> | |
<p>Your teammates at <strong>{{ organization.name|sanitize_periods }}</strong> are using Sentry to catch errors, improve latency issues, and keep their (and maybe your) code from catching fire. 🔥</p> |
⚡ Committable suggestion
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Context for Agents
[**BestPractice**]
Template variable filtering inconsistency: The original code used `{{ organization.name|sanitize_periods }}` but the new code uses `{{ organization.name }}` without the filter. This could introduce security issues or rendering problems if organization names contain periods that need sanitization.
```suggestion
<p>Your teammates at <strong>{{ organization.name|sanitize_periods }}</strong> are using Sentry to catch errors, improve latency issues, and keep their (and maybe your) code from catching fire. 🔥</p>
```
⚡ **Committable suggestion**
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
File: src/sentry/templates/sentry/emails/member-invite.html
Line: 8
<div class="notice">Do <strong>not</strong> share this invite email or link. This invite is unique to you. Sharing may result in unauthorized access.</div> | ||
<p>👉 <a href="{{ url }}" class="btn">Accept your invite</a></p> | ||
|
||
<div class="notice">Heads up: this invite link is just for you. Don't share it unless you want random strangers fixing your bugs.</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[NitPick]
Inconsistent indentation: Line 15 has extra leading spaces (5 spaces instead of 4) compared to other elements at the same nesting level.
<div class="notice">Heads up: this invite link is just for you. Don't share it unless you want random strangers fixing your bugs.</div> | |
<div class="notice">Heads up: this invite link is just for you. Don't share it unless you want random strangers fixing your bugs.</div> |
⚡ Committable suggestion
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Context for Agents
[**NitPick**]
Inconsistent indentation: Line 15 has extra leading spaces (5 spaces instead of 4) compared to other elements at the same nesting level.
```suggestion
<div class="notice">Heads up: this invite link is just for you. Don't share it unless you want random strangers fixing your bugs.</div>
```
⚡ **Committable suggestion**
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
File: src/sentry/templates/sentry/emails/member-invite.html
Line: 15
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Copied from getsentry#101056
Original PR: getsentry#101056