Skip to content

Conversation

jasonyuezhang
Copy link
Owner

Problem
Previously, we disabled users from creating 'other' platforms, but this was later reverted. However, we missed reverting a validation in project creation that blocks users from proceeding if they don’t explicitly select a platform - they could choose 'other', for example.

image

Solution
This PR reverts that validation, so if no platform is selected, an 'other' platform is created automatically as it was before (see).

Bildschirmaufnahme.2025-10-07.um.10.36.21.mov

closes https://linear.app/getsentry/issue/TET-1248/project-creation-make-sure-button-is-deactivated-when-platform-is


Copied from getsentry#101059
Original PR: getsentry#101059

Copy link

Project Creation Now Defaults to 'Other' Platform When None Selected

This PR updates the project creation flow to automatically assign the 'other' platform if the user does not explicitly select a platform when creating a project. Previously, an enforced validation blocked creation unless a platform was chosen, but this behavior conflicted with the reverted decision to permit 'other' projects. The changes ensure parity with earlier project creation logic and simplify code paths by allowing projects without a specific platform selection. Supporting types, utility, and test files are updated to accommodate the relaxed validation and assignment logic.

Key Changes

• Removed strict validation that required a platform selection during project creation in static/app/views/projectInstall/createProject.tsx.
• Updated project creation logic to default to the otherPlatform if no platform is chosen.
• Adjusted type definitions in static/app/types/onboarding.tsx and function signatures to allow platform to be optional.
• Modified the test suite static/app/views/projectInstall/createProject.spec.tsx to cover and validate the new 'other' platform behavior and ensure button enablement logic matches.
• Refactored utility usage for platform types and integrations in affected files.
• Adjusted API request logic in static/app/components/onboarding/useCreateProject.ts to handle absence of a platform field.

Affected Areas

static/app/views/projectInstall/createProject.tsx
static/app/views/projectInstall/createProject.spec.tsx
static/app/components/onboarding/useCreateProject.ts
static/app/components/onboarding/useCreateProjectAndRules.ts
static/app/types/onboarding.tsx
static/app/utils/platform.tsx

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants