Document that rejectRequestWith requires closing the stream #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just ran into the same issue described in [jaspervdj#211](jaspervdj#211). In my case I had noticed the note about calling `Stream.close` in the `rejectRequest` docs but I didn't realize that the disclaimer applied to `rejectRequestWith` as well. Based on [this comment](jaspervdj#211 (comment)) maybe it makes sense to close the underlying stream when rejecting the request, but short of that maybe this note will help someone else avoid the same issue.
Owner
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into the same issue described in #211. In my case I had noticed the note about calling
Stream.closein therejectRequestdocs but I didn't realize that the disclaimer applied torejectRequestWithas well. Based on this comment maybe it makes sense to close the underlying stream when rejecting the request, but short of that maybe this note will help someone else avoid the same issue.