fix: pre plugin installation users not being connected#12
Open
ashemsay wants to merge 1 commit intojasperweyne:masterfrom
Open
fix: pre plugin installation users not being connected#12ashemsay wants to merge 1 commit intojasperweyne:masterfrom
ashemsay wants to merge 1 commit intojasperweyne:masterfrom
Conversation
Check if a user with the same username already exists before registering, if so don't try to create a new user, only handle the oidc part
|
I stumbled upon the same problem with piwigo 13. I tried your patch, but it needs a bit of work. The users table name is not fixed, it can be prefixed. When I hardcoded my table name, it sort of worked, but overwrote the username with an UID (I have "username" in the "preferred username" part of the plugin config). I fixed that manually in the DB and the SSO seems to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I installed and configured the plugin but when I tried to log back in with my account it did not work.
It turns out oidc users can't be logged in if they where already registered before the installation of the plugin.
That is a big issue for me because:
I added a test to verify if a user with the same username already exists before registering, if so don't try to create a new user but only handle the oidc table part.