Skip to content

fix: pre plugin installation users not being connected#12

Open
ashemsay wants to merge 1 commit intojasperweyne:masterfrom
ashemsay:fix/cant-connect-existing-accounts
Open

fix: pre plugin installation users not being connected#12
ashemsay wants to merge 1 commit intojasperweyne:masterfrom
ashemsay:fix/cant-connect-existing-accounts

Conversation

@ashemsay
Copy link
Copy Markdown

I installed and configured the plugin but when I tried to log back in with my account it did not work.
It turns out oidc users can't be logged in if they where already registered before the installation of the plugin.
That is a big issue for me because:

  • I am the only admin
  • practically all the users that are going to use oidc already exist in the database since I am migrating from a very old ldap plugin to keycloak using the same ldap server as backend.

I added a test to verify if a user with the same username already exists before registering, if so don't try to create a new user but only handle the oidc table part.

Check if a user with the same username already exists before
registering, if so don't try to create a new user, only handle the oidc
part
@netchild
Copy link
Copy Markdown

I stumbled upon the same problem with piwigo 13. I tried your patch, but it needs a bit of work. The users table name is not fixed, it can be prefixed. When I hardcoded my table name, it sort of worked, but overwrote the username with an UID (I have "username" in the "preferred username" part of the plugin config). I fixed that manually in the DB and the SSO seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants