Add a default value for password_test_user and password_test_pass for configuration page#27
Open
armanddidierjean wants to merge 2 commits intojasperweyne:masterfrom
Conversation
|
Any news on when this will be pushed? |
armanddidierjean
force-pushed
the
fix-php-error-in-configuration-page
branch
from
d2405a7 to
f5f0dac
Compare
|
Hello @jasperweyne are you still working on this project ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #26
Hello,
I tried to use this plugin with recent version of Piwigo and PHP 8, as explained by #26 php now raise errors which are displayed in the module configuration page.
There may be more efficient ways to fix the error but providing a default value for
password_test_userandpassword_test_passworks well.