Bugfix for migration #167
Bugfix for migration #167
Conversation
…t fields and clarify INSERT statement
There was a problem hiding this comment.
Pull request overview
This pull request addresses a migration bug and includes dependency updates along with release notes for version 1.2.0. The PR primarily focuses on fixing the INSERT statement in a database migration to explicitly specify column names, which improves migration safety and clarity.
Changes:
- Updated multiple dependencies to their latest minor/patch versions (Svelte 5.46.4 → 5.47.1, @sveltejs/kit 2.49.5 → 2.50.0, TypeScript ESLint 8.53.0 → 8.53.1, and @inlang/paraglide-js 2.9.0 → 2.9.1)
- Fixed migration SQL to explicitly specify columns in INSERT statement instead of using SELECT *
- Added comprehensive release notes for v1.2.0 documenting new features, improvements, and bug fixes
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated 5 dev dependencies to latest minor/patch versions |
| pnpm-lock.yaml | Updated lockfile to reflect new dependency versions and their transitive dependencies |
| migrations/20260120190621_make_odometer_and_volume_optional.sql | Fixed INSERT statement to explicitly list columns and maintained tinyint(1) type declarations for consistency with existing migrations |
| changelogs/1.2.0.md | Added comprehensive release notes for v1.2.0 with features, improvements, and migration notes |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| filled tinyint(1) NOT NULL, | ||
| missed_last tinyint(1) NOT NULL, |
There was a problem hiding this comment.
There is an inconsistency in the data type declarations within this migration. The new fields use proper SQLite types (TEXT, INTEGER, REAL) but the filled and missed_last columns use MySQL-style tinyint(1) syntax. For consistency and clarity, these should be changed to INTEGER to match the SQLite convention used in the rest of the CREATE TABLE statement. While SQLite will treat tinyint(1) as INTEGER with INTEGER affinity, using the standard SQLite type improves readability and consistency.
| filled tinyint(1) NOT NULL, | |
| missed_last tinyint(1) NOT NULL, | |
| filled INTEGER NOT NULL, | |
| missed_last INTEGER NOT NULL, |
No description provided.