feat: add UserAgentPeerProvider configuration option to Provider#60
Merged
feat: add UserAgentPeerProvider configuration option to Provider#60
Conversation
Adds a UserAgentPeerProvider interface and field to Provider, mirroring the pattern introduced in nntpcli. The user agent string is threaded through runConnSlot and newNNTPConnectionFromConn into NNTPConnection, making it available for future use (e.g. article POST headers).
Replaces the UserAgentPeerProvider interface with a plain string field Provider.UserAgent, removing unnecessary indirection since the user agent value is static at configuration time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserAgentPeerProviderinterface (GetUserAgent() string) to nntppool, mirroring the pattern introduced in nntpcliUserAgentPeerProvider UserAgentPeerProviderfield toProviderstruct — optional, nil-saferunConnSlot→newNNTPConnectionFromConn→NNTPConnection, where it is stored for future use (e.g. automaticUser-Agentheader injection in article POSTs)Test plan
TestUserAgentPeerProvider_StoredOnConnection— verifies a configured provider is stored on the connection and returns the correct stringTestUserAgentPeerProvider_NilIsAccepted— verifies nil is handled gracefully (no panic, field stays nil)nilfor the new parameter —make checkpasses clean