fix: round-robin dispatch panics with more than 8 providers#61
Merged
Conversation
…patch The weighted round-robin cumulative weights array was hard-coded to size 8, causing an index-out-of-range panic when more than 8 main providers were configured. Replace with make([]int, n) sized to the actual provider count. Adds a regression test with 9 providers to prevent recurrence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[8]intcumulative-weights array indoSendWithRetrywith a dynamically-sizedmake([]int, n)slice[:n]slice expression on thesort.SearchIntscallTestClient_RoundRobinMoreThan8Providersto prevent regressionRoot cause
Any deployment with 9+ main providers hit an immediate
runtime error: index out of rangepanic.Test plan
go test -run TestClient_RoundRobinMoreThan8Providers -race ./...passes