fix: align PAR2 slice size to multiple of 4 as required by spec#200
Merged
fix: align PAR2 slice size to multiple of 4 as required by spec#200
Conversation
The par2go library requires SliceSize to be a positive multiple of 4. When articleSize (from posting config) was not a multiple of 4, calculateParBlockSize returned it unaligned, causing par2 creation to fail with "SliceSize must be a positive multiple of 4". Extract maxPar2Blocks constant, add alignDown helper, and ensure all code paths produce a spec-compliant block size. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
par2go: SliceSize must be a positive multiple of 4, got 361254calculateParBlockSize()now always returns a value aligned to a multiple of 4maxPar2Blocksconstant (was magic number32768) from the PAR2 speccreatePar2ForFile()before callingpar2go.Create()Root Cause
articleSize(fromposting.article_size_in_bytes) is not guaranteed to be a multiple of 4. When the file was larger thanarticleSize, the existing SIMD alignment guard never triggered, so the unaligned value was passed directly topar2go.Create()which rejected it.Related #198