Added support for a brazilian exchange trader MercadoBitcoin#3
Open
arianpasquali wants to merge 9 commits intojawerty:masterfrom
Open
Added support for a brazilian exchange trader MercadoBitcoin#3arianpasquali wants to merge 9 commits intojawerty:masterfrom
arianpasquali wants to merge 9 commits intojawerty:masterfrom
Conversation
added 9 commits
December 10, 2013 18:36
Owner
|
Thank you for the contribution. However, isn't mercado bitcoin a smaller exchange? Your documenting it like its separate from the other exchanges, like a major market. If I merge, do you mind if I change the code to make it less individualistic to the other code and markets so it doesn't seem like btcl is partial to mercado bitcoin? |
Author
|
Indeed is a smaller exchange compared to the others, but it is maybe the most active in Brazil. I don't mind at all if you change or adapt the code to be more generic. You are right. It seams partial the way it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I altered the code to add support for a new trader that is not covered by bitcoincharts API.
I'm not a ruby expert so it may not be the best implementation, but I wanted to share it anyway.
best