Skip to content

Make nvidia version data optional for ROCm builds #33186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make nvidia version data optional for ROCm builds #33186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e668f
Make nvidia version data optional for ROCm builds
phambinhfin Oct 31, 2025
b8bc254
Maintain the requirement for CUDA builds
phambinhfin Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jaxlib/tools/build_gpu_kernels_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,14 @@
parser.add_argument(
"--nvidia_wheel_versions_data",
default=None,
required=True,
required=False,
help="NVIDIA wheel versions data",
)
args = parser.parse_args()

if args.enable_cuda and not args.nvidia_wheel_versions_data:
parser.error('argument --nvidia_wheel_versions_data is required for CUDA builds')

r = runfiles.Create()
pyext = "pyd" if build_utils.is_windows() else "so"

Expand Down
5 changes: 3 additions & 2 deletions jaxlib/tools/build_gpu_plugin_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,12 @@
parser.add_argument(
"--nvidia_wheel_versions_data",
default=None,
required=True,
required=False,
help="NVIDIA wheel versions data",
)
args = parser.parse_args()

if args.enable_cuda and not args.nvidia_wheel_versions_data:
parser.error('argument --nvidia_wheel_versions_data is required for CUDA builds')
r = runfiles.Create()


Expand Down