Skip to content

[remat] Make prevent_cse's tuple form account for consts #33217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

[remat] Make prevent_cse's tuple form account for consts #33217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jax/_src/ad_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,8 @@ def fun_remat(*args, **kwargs):
in_avals = [core.shaped_abstractify(x) for x in args_flat]
jaxpr, consts, out_tree = _trace_to_jaxpr(fun_, in_tree, tuple(in_avals), debug)
if isinstance(prevent_cse, tuple):
cse = (*broadcast_prefix(prevent_cse, (args, kwargs) if kwargs else args),)
cse_args = (tuple(args), kwargs) if kwargs else tuple(args)
cse = (False,) * len(consts) + tuple(broadcast_prefix(prevent_cse, cse_args))
else:
cse = prevent_cse
out_flat = remat_p.bind(
Expand Down
4 changes: 3 additions & 1 deletion tests/api_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7117,7 +7117,9 @@ def make_weight(i):
def test_remat_partial_cse_prevention(self):
@partial(jax.remat, prevent_cse=(False, True))
def layer(W, x):
return x @ W
res = x @ W
res += jnp.array([1.0, 2.0, 3.0]) # ensure the jaxpr also contains a const
return res

def net(Ws, x):
for W in Ws:
Expand Down
Loading