Fix golangci-lint discovered issues #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay7x
force-pushed
the
fix_lint
branch
9 times, most recently
from
8bdd8c7 to
cdb7a75
Compare
* disable paramTypeCombine gocritic check * disable staticcheck ST1005,ST1003 rules * disable depguard, lll, mnd, funlen linters for now
* drop unused function args * fix goimports issue (formatting) * fix whitespace issues (formatting) * fix unnecessary convert issue * fix spelling issues * fix some errcheck issues * fix noctx lint issue * unshadow docs module (gocritic) * delete unused function parameter * drop unused code, name output params * fix more gocritic lint issues * fix more gocritic issues * replace deprecated io/ioutil * replace deprecated cobra.ExactValidArgs() * replace deprecated cobra.SetOutput() * replace deprecated strings.Title() * remove unnecessary assignment * remove most of nolint comments * fix assignOp gocritic issues * use new octal literal style (gocritic) * fix more gocritic issues * delete commented-out code * fix goconst issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.