VolumeIntegrals_vacuumX: Schedule fix and restrict M_ADM to interior#6
Merged
jaykalinani merged 4 commits intojaykalinani:mainfrom Apr 9, 2026
Merged
VolumeIntegrals_vacuumX: Schedule fix and restrict M_ADM to interior#6jaykalinani merged 4 commits intojaykalinani:mainfrom
jaykalinani merged 4 commits intojaykalinani:mainfrom
Conversation
Merging Jays changes
…tion. Main schedule group is now enforced to run after z4c analysis group, to ensure that the Hamiltonian constraint is updated. Additionally, the M_ADM integrand now manuallay excludes the boundary/ghost zone contribution using 'grid.box_int'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce the main VI_vacuumX_VolumeIntegralGroup group runs after Z4c_AnalysisGroup so the Hamiltonian constraints are up to date, additionally restrict the M_ADM volume integral to only include contributions from interior zones, excluding ghost zones and boundary condition effects.