Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These optimizations have been demonstrated to work with a 1D thin advection test and the 3D homogenous sphere test, and demonstrated to be faster than the current debug branch in the 1D test on 2 processes. Note that the new loop macro is defined in my CarpetX development branch (https://github.com/acwen11/CarpetX/blob/development/Loop/src/loop_device.hxx#L190), but it should be simple to copy it over to your nuX branch of CarpetX. This will also not work with poisoning without "cheating" by initializing gridfunctions to zero when they are written in the interior only.