Skip to content

Add new include for PropTypes #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plastbox wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add new include for PropTypes #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e205fdc
Add new include for PropTypes
plastbox Apr 11, 2018
e5225c5
Keep value on re-render
plastbox Apr 12, 2018
0b2fe81
Remove componentWillReceiveProps
Mar 31, 2020
4063296
Upped version number.
Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-prompt",
"version": "1.0.0",
"version": "1.0.1",
"description": "A cross-platform prompt component for React Native.",
"repository": {
"type": "git",
Expand Down
17 changes: 14 additions & 3 deletions src/Prompt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { Component, PropTypes } from 'react';
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import {
Modal,
Platform,
Expand Down Expand Up @@ -60,9 +61,18 @@ export default class Prompt extends Component {
this.setState({value: this.props.defaultValue});
}

componentWillReceiveProps(nextProps) {
/*componentWillReceiveProps(nextProps) {
const { visible, defaultValue } = nextProps;
this.setState({ visible, value:defaultValue });
if(visible !== this.props.visible && visible) {
this.setState({ visible, value: defaultValue });
}
}*/
static getDerivedStateFromProps(nextProps, prevState) {
const { visible, defaultValue } = nextProps;
if(visible !== nextProps.visible && visible) {
return { visible: defaultValue };
}
return null;
}

_onChangeText = (value) => {
Expand Down Expand Up @@ -114,6 +124,7 @@ export default class Prompt extends Component {
<TextInput
style={[styles.dialogInput, inputStyle]}
defaultValue={defaultValue}
value={this.state.value}
onChangeText={this._onChangeText}
placeholder={placeholder}
autoFocus={true}
Expand Down