-
Notifications
You must be signed in to change notification settings - Fork 15
Add make_indirect and make_polymorphic extensions
#546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 11 11
Lines 748 760 +12
Branches 76 76
=======================================
+ Hits 745 757 +12
Misses 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Are you proposing these for the Standard? did LEWG/LWG ask for them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'm in favour of the added consistency these bring.
|
These have not been asked for. They'd need adding as a NB comment, a library defect or as part of C++29. I'd want collaborators on the standardisation effort. |
I'm certainly happy to help craft wording and/or coauthor (or not). I'd like to see these get in, too. Procedurally, as a design issue, this would not be a defect/LWG-issue; but as a kind of "bugfix" to new-in-C++26 material (from the original authors no less), the paper should have no trouble getting seen in LEWG in a timely fashion. |
|
LGTM :) |
|
@Quuxplusone @Ukilele this PR is looking for an owner who's willing or able (ideally both) to write a paper/issue for C++26. |
@Quuxplusone @Ukilele this may be of interest to you both.