Conversation
…yService Agent-Logs-Url: https://github.com/jbcrane13/NetMonitor-2.0/sessions/8e9ccd9a-d26e-41de-b657-0b15674b2101 Co-authored-by: jbcrane13 <25068427+jbcrane13@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update documentation for NetMonitor features
fix: remove invalid Apr 10, 2026
private(set) on computed property in ObservabilityService
jbcrane13
approved these changes
Apr 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Swift compilation error in ObservabilityService by removing an invalid private(set) modifier from a getter-only computed property, unblocking the Coverage Gates CI pipeline.
Changes:
- Removed
private(set)fromisInitialized(illegal on getter-only computed properties). - Simplified the computed property getter to a single-expression body.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swift compilation error in
ObservabilityService.swiftwas breaking the Coverage Gates CI pipeline.private(set)is only valid on storedvardeclarations — not on read-only computed properties.Changes
private(set)fromisInitializedcomputed property — the modifier is illegal on a getter-only computed var; the property was already externally immutable by virtue of having no setterget { }wrapper)Testing Done
xcodebuild test -scheme NetMonitor-macOSon mac-mini)xcodebuild test -scheme NetMonitor-iOSon mac-mini)swiftlint lint --quiet)swiftformat --lint .)Notes for Reviewer
No behavioral change — a getter-only computed property has no setter regardless of access modifiers. The fix is purely syntactic.