Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances test coverage for vecsync's CLI commands by adding new tests for CLI operations and consolidating testing fixtures.
- Removed tests from tests/openai/conftest.py and integrated their functionality into tests/conftest.py
- Added new test files for CLI commands: sync, store, settings, and assistants
- Updated the CHANGELOG to reflect new tests and fixture reorganization
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/openai/conftest.py | Removed; its functionality appears consolidated into tests/conftest.py |
| tests/conftest.py | Added and updated shared mock classes and fixtures for testing |
| tests/cli/test_cli_sync.py | Added tests for syncing file source via CLI |
| tests/cli/test_cli_store.py | Added tests for listing and deleting files from vector store |
| tests/cli/test_cli_settings.py | Added tests for showing and clearing settings |
| tests/cli/test_cli_assistants.py | Added tests for listing and cleaning assistants |
| src/vecsync/cli/settings.py | Minor update to add a confirmation message when settings are cleared |
| src/vecsync/cli/entry.py | Added a pragma line to exclude file from coverage |
| src/vecsync/cli.py | Removed, likely due to CLI refactoring |
| CHANGELOG.md | Updated to include new tests and fixture reorganization |
Comments suppressed due to low confidence (2)
tests/openai/conftest.py:1
- Ensure that the removal of this file is intentional and that all tests previously relying on its fixtures now correctly reference those in tests/conftest.py.
Entire file removal.
src/vecsync/cli/settings.py:12
- The function 'colored' is used without being imported, which will cause a NameError at runtime. Please import 'colored' from the 'termcolor' module or replace its usage with an already imported function (e.g., cprint).
click.echo(colored("Settings file cleared.", "green"))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes issue #18 by adding test coverage for most CLI commands. Prompt response and Gradio UI currently remain uncovered.
Test Plan
Pass tests