Improve macOS ARM build: EPICS/PVA support, Python fixes, and clean test suite#57
Open
drvegabermudez wants to merge 9 commits intojbengtsson:mainfrom
Open
Improve macOS ARM build: EPICS/PVA support, Python fixes, and clean test suite#57drvegabermudez wants to merge 9 commits intojbengtsson:mainfrom
drvegabermudez wants to merge 9 commits intojbengtsson:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize CMake for macOS ARM: raise minimum versions, quiet policies/Boost, add arm64 EPICS host/target detection, map AppleClang→clang, and wire EPICS compiler/os include paths.
Enable EPICS/PVA and OpenMP: configure TRY_EPICS, remove unused Boost components, set Homebrew libomp paths, and propagate OpenMP includes.
Fix Python integration: switch flame/pyconfig.py to sysconfig (distutils-free), skip nose on Python ≥3.12, add thor shim package and math re-export, and ensure Python extensions build against the installed prefix.
Resolve build blockers: add missing headers, remove unused GSL includes, add override specifiers, correct multipole defaults (B_n/K) and main multipole numbers for bend/sextupole; C++ ctest now passes 34/34.
Docs and install: expand macOS ARM64 README quickstart with full CMake configure line; install artifacts to install/ prefix; build and install gtpsa and thor_scsi Python wheels.
Note remaining Python test gaps: some tests reference a missing external lattice file, expect unexported constants, rely on an unshipped _gtpsa_variant_test, and hit placeholder utilities (jac_intern_to_std, Matrix binding); these need follow-up or test adjustments.