Minor fixes for 64-bit systems and -m argument for chaser delay #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0tobsam0
commented
Jan 14, 2024
0tobsam0
commented
- created switch for 32-bit and 64-bit pointer type (uint32_t and size_t)
- added command line argument for chaser delay
- use "gcc -Wall -fcommon -o rpi_pixleds rpi_pixleds.c rpi_dma_utils.c" to compile
- build with "gcc -Wall -fPIC -shared -o rpi_pixleds.so rpi_pixleds_lib.c rpi_dma_utils.c"
dolby360
reviewed
Mar 3, 2024
There was a problem hiding this comment.
Agreed. A code repo is not the place for binaries.
|
Thank you for the PR. I like some of the changes, but it needs some work first IMO. Does the library work? The commit message isn't very clear. You may have better luck breaking this into individual PRs per feature. |
|
Did all the stuff to convert into 64bit but I still have a segmentation fault when I run rpi_dma_test. Any help :) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.