-
Notifications
You must be signed in to change notification settings - Fork 5
Update phydms to be compatible with latest dependency versions #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
jbloom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidrich27, thanks for the pull request.
I am probably too out of loop of looking at code to be super effective at managing this review, so I've also made @Haddox a repo admin so he can review and eventually merge.
I do have on requested change to note now though: update the version number here to match the CHANGELOG version increment.
|
@jbloom Yep, I made the version changes to metadata as well as the changelog. |
|
I looked over the entire pull request and it looks good to me. We also made sure that we could reproduce the results in the tutorial. |
Fixes to phydms to be compatible with latest dependency versions.
Changes:
scipy, which has been deprecated/removed from latestscipy.pyvolvefor updated seed api.