Skip to content

Conversation

@davidrich27
Copy link
Collaborator

Fixes to phydms to be compatible with latest dependency versions.

Changes:

  • Includes derivative function from scipy, which has been deprecated/removed from latest scipy.
  • Updates tests using pyvolve for updated seed api.
  • Updates numpy to pandas data for updated api (declarations, array access, etc).
  • Updates to tutorial to use python3 syntax.
  • Updates to raw string syntax for regualar expressions.

Copy link
Member

@jbloom jbloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidrich27, thanks for the pull request.

I am probably too out of loop of looking at code to be super effective at managing this review, so I've also made @Haddox a repo admin so he can review and eventually merge.

I do have on requested change to note now though: update the version number here to match the CHANGELOG version increment.

@davidrich27
Copy link
Collaborator Author

@jbloom Yep, I made the version changes to metadata as well as the changelog.

@davidrich27 davidrich27 requested a review from jbloom July 9, 2025 00:41
@Haddox
Copy link
Collaborator

Haddox commented Jul 9, 2025

I looked over the entire pull request and it looks good to me. We also made sure that we could reproduce the results in the tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants