compute population rather than sample std for PolyclonalCollection
#189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute standard deviations for `PolyclonalCollection` using population rather than sample standard deviations. This changes the values of these standard deviations (makes them smaller), makes them zero rather than NaN when only one model being averaged, and fixes problem with `PolyclonalCollection` plots when only a single model.
jbloom
added a commit
to dms-vep/dms-vep-pipeline-3
that referenced
this pull request
Apr 7, 2025
Upgrade to `polyclonal` 6.16 which integrates [this change](jbloomlab/polyclonal#189) which computes standard deviation of escape values when average models as the population rather than sample standard deviation. This fixes a bug that was causing plots to fail when just one model was being averaged. Now when there is just one model, the standard deviation is 0 rather than NaN. Also, other standard deviations will tend to be a bit smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute standard deviations for
PolyclonalCollectionusing population rather than sample standard deviations. This changes the values of these standard deviations (makes them smaller), makes them zero rather than NaN when only one model being averaged, and fixes problem withPolyclonalCollectionplots when only a single model.