Generalize to Callables Instead of Strictly Lambdas#327
Generalize to Callables Instead of Strictly Lambdas#327jborean93 merged 9 commits intojborean93:masterfrom
Conversation
|
Thanks Jayson. Change looks good. Maybe it make sense to add at least one test that uses a callable...similar to lamba test smbprotocol/tests/test_structure.py Lines 369 to 379 in c3be43d Also... maybe also enable Windows 2025 ? The changes will need to be approved and merge by Jordan ... but I tool a look Thanks again |
9ce8684 to
7905b44
Compare
|
Thanks for setting this up, I'm hoping to get to this by the end of the week. |
jborean93
left a comment
There was a problem hiding this comment.
The changes look good, just needs a rebase now that the CI has been updated.
|
Applied the CI changes. Should be merge-able now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 24 24
Lines 5176 5177 +1
=======================================
+ Hits 5126 5127 +1
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the update, changes look good. |
For fields that accept a lambda, generalize it to accept a callable in general.
This allows some code to be simplified for programs using the package. For example:
Can be simplified into:
Also updated the CI to exclude Windows 2019 as it is no longer supported (see: actions/runner-images#12045)