Skip to content

Fix copy/copy2 kwargs handling #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jborean93 merged 1 commit into from
Feb 8, 2026
Merged

Fix copy/copy2 kwargs handling #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Optimize `SMBDirEntry.is_symlink()`, returned by `smbclient.scandir()` to no longer require any extra SMB calls, this object is returned by APIs such as `
* Raise exception when receiving an SMB `STATUS_STOPPED_ON_SYMLINK` response that contains no reparse buffer data
* Some SMB servers like macOS do not return this information
* Fix up `smbclient.shutil.copy` and `smbclient.shutil.copy2` to properly pass along the connection `kwargs` to the internal copy call

## 1.15.0 - 2024-11-12

Expand Down
4 changes: 2 additions & 2 deletions src/smbclient/shutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,8 @@ def _copy(src, dst, follow_symlinks, copy_meta_func, **kwargs):
if (is_remote_path(ntpath.normpath(dst)) and isdir(dst, **kwargs)) or os.path.isdir(dst):
dst = _join_local_or_remote_path(dst, _basename(src))

copyfile(src, dst, follow_symlinks=follow_symlinks)
copy_meta_func(src, dst, follow_symlinks=follow_symlinks)
copyfile(src, dst, follow_symlinks=follow_symlinks, **kwargs)
copy_meta_func(src, dst, follow_symlinks=follow_symlinks, **kwargs)
return dst


Expand Down