Conversation
Fixes the response handler to raise the `STATUS_STOPPED_ON_SYMLINK` when trying to open a symlink but the server does not return the reparse buffer. This behaviour has been seen on server implementations like macOS. The SMBDirEntry symlink type tests also treat this as having no valid target.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 99.03% 99.01% -0.02%
==========================================
Files 24 24
Lines 5177 5184 +7
==========================================
+ Hits 5127 5133 +6
- Misses 50 51 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the response handler to raise the
STATUS_STOPPED_ON_SYMLINKwhen trying to open a symlink but the server does not return the reparse buffer. This behaviour has been seen on server implementations like macOS. The SMBDirEntry symlink type tests also treat this as having no valid target.Fixes: #333