Skip to content

Conversation

@bdecoste
Copy link
Contributor

@bdecoste bdecoste commented Oct 4, 2017

No description provided.

"imageChange": {
"from": {
"kind": "ImageStreamTag",
"name": "jboss-datagrid65-client-openshift:1.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be using datagrid71 client

"from": {
"kind": "ImageStreamTag",
"namespace": "${IMAGE_STREAM_NAMESPACE}",
"name": "jboss-datagrid65-client-openshift:1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdecoste You might want to updates this to "jboss-datagrid71-client-openshift:1.0"

},
"paths": [
{
"destinationDir": "./${CONTEXT_DIR}/extensions/datagrid65",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s#./${CONTEXT_DIR}/extensions/datagrid65"#./${CONTEXT_DIR}/extensions/datagrid71"# ?

"imageChange": {
"from": {
"kind": "ImageStreamTag",
"name": "jboss-datagrid65-client-openshift:1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/jboss-datagrid65-client-openshift:1.0/jboss-datagrid71-client-openshift:1.0/

"from": {
"kind": "ImageStreamTag",
"namespace": "${IMAGE_STREAM_NAMESPACE}",
"name": "jboss-datagrid65-client-openshift:1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/jboss-datagrid65-client-openshift:1.0/jboss-datagrid71-client-openshift:1.0/

},
"paths": [
{
"destinationDir": "./${CONTEXT_DIR}/extensions/datagrid65",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s#./${CONTEXT_DIR}/extensions/datagrid65#./${CONTEXT_DIR}/extensions/datagrid71# ?

@vhalbert
Copy link
Contributor

Changes need to be made:

"value": "datavirt/dynamicvdb-datafederation/app" needs to be changed to the new datavirt4/.... directory. The new JDV 6.4 quickstart will need to have a new directory, so that JDV 6.3 isn't corrupted.

Also, not sure why the ModeShape username/passwords setting were removed.

@vhalbert
Copy link
Contributor

This PR is no longer valid, the templates have been moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants