🐛 Fix: render format + latestSet at the right spot in deck forms#514
Merged
🐛 Fix: render format + latestSet at the right spot in deck forms#514
Conversation
Both fields were missing from the explicit form_row calls in the deck new and edit templates, so form_end was emitting them at the bottom of the form (after the submit button area in some layouts). - new.html.twig: format goes right after name; latestSet sits between the languages island and the public checkbox (matching edit.html.twig). - edit.html.twig: format added right after name. latestSet was already in place.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both fields were missing from the explicit
form_rowcalls in the deck templates, soform_end(form)was emitting them after the submit button (or wherever Symfony's auto-render dropped them):templates/deck/new.html.twigwas missing bothformatandlatestSet.templates/deck/edit.html.twigwas missing onlyformat—latestSetwas already in the template.Fix
formatrendered right afternameon both forms.latestSetrendered between the languages React island and thepubliccheckbox on the new template (matching the edit template's existing position).Test plan
make twig-cs-check— all 103 templates cleanmake test.functionalfiltered toDeckControllerTest— 28 / 28 pass (covers both new + edit form render and submit)make start, click "New deck" and "Edit deck" to confirm both fields appear in the right place🤖 Generated with Claude Code