Skip to content

Conversation

@julkue
Copy link

@julkue julkue commented May 21, 2016

Here you go.
Closes #19

@julkue
Copy link
Author

julkue commented Jul 19, 2016

Ping @jbr

@jbr
Copy link
Owner

jbr commented Jul 19, 2016

@julmot What improvement over the existing demo does the codepen demo offer? Could the existing demo be improved or replaced?

@jbr
Copy link
Owner

jbr commented Jul 19, 2016

I would happily accept changes to https://github.com/jbr/jQuery.highlightRegex/blob/master/index.html if there are features that would improve it

@julkue
Copy link
Author

julkue commented Jul 19, 2016

Feel free to PR a link to that url to the README

what's wrong now?

@julkue
Copy link
Author

julkue commented Jul 19, 2016

  1. It is responsive
  2. It is colorized
  3. It allows users to enter custom modifiers
  4. It allows users to specify custom options

@jbr
Copy link
Owner

jbr commented Jul 19, 2016

I realized there was no reason to have two similar examples. I'd like to replace index.html with something like yours, if you think those four improvements would help people get a sense of the plugin.

@julkue
Copy link
Author

julkue commented Jul 20, 2016

Well, I think both examples give a quick overview and beside of more options the CodePen demo offers a better UX.
So the choice is yours 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants