Skip to content

Improvements #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcarolus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improvements #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b6ce44
prep for RTL languages in layouts
Mar 26, 2026
5dedd36
add Arabic translations
Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ android {
applicationId "jwtc.android.chess"
minSdkVersion 24
targetSdkVersion 36
resourceConfigurations += ['en', 'zh', 'it', 'pt', 'es', 'ru', 'de', 'fr', 'tr', 'ro']
resourceConfigurations += ['en', 'zh', 'it', 'pt', 'es', 'ru', 'de', 'fr', 'tr', 'ro', 'ar']
// place correct redirectScheme~
manifestPlaceholders = [appAuthRedirectScheme: 'jwtc.android.chess']
}
Expand Down
1 change: 1 addition & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
android:label="@string/app_name"
android:theme="@style/ChessTheme"
android:banner="@drawable/ic_feature"
android:supportsRtl="true"
android:enableOnBackInvokedCallback="false"
android:resizeableActivity="true">
<service
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout-land/gameslist.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
android:layout_height="0dp"
android:layout_width="0dp"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintStart_toEndOf="@id/board_area"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintBottom_toTopOf="@id/LayoutMenu" />

Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout-land/random_fischer.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
android:id="@+id/ButtonSetupOptionsCancel"
android:text="@string/button_cancel"
android:layout_width="wrap_content"
android:layout_marginRight="2dp"
android:layout_marginEnd="2dp"
style="@style/ChessButton" />

<com.google.android.material.button.MaterialButton
Expand All @@ -109,7 +109,7 @@
android:id="@+id/ButtonSetupOptionsOk"
android:text="@string/button_ok"
android:layout_width="wrap_content"
android:layout_marginLeft="2dp"
android:layout_marginStart="2dp"
style="@style/ChessButton" />
</TableRow>

Expand Down
36 changes: 18 additions & 18 deletions app/src/main/res/layout/chessboard_prefs_controls.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,41 +58,41 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<CheckBox
android:id="@+id/CheckBoxUseSound"
android:text="@string/pref_sound"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<CheckBox
android:id="@+id/CheckBoxUseHapticFeedback"
android:text="@string/pref_haptic_feedback"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<CheckBox
android:id="@+id/CheckBoxUseWakeLock"
android:text="@string/pref_wakelock"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<TextView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginLeft="32dip"
android:layout_marginRight="8dip"
android:layout_marginStart="32dip"
android:layout_marginEnd="8dip"
android:layout_marginBottom="8dip"
android:text="@string/pref_wakelock_desc" />

Expand All @@ -102,14 +102,14 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<TextView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginLeft="32dip"
android:layout_marginRight="8dip"
android:layout_marginStart="32dip"
android:layout_marginEnd="8dip"
android:layout_marginBottom="8dip"
android:text="@string/pref_fullscreen_desc" />

Expand All @@ -119,14 +119,14 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<TextView
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginLeft="32dip"
android:layout_marginRight="8dip"
android:layout_marginStart="32dip"
android:layout_marginEnd="8dip"
android:layout_marginBottom="8dip"
android:text="@string/pref_night_mode_desc" />
</LinearLayout>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/full_pgn.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<TableRow
style="@style/MyRowStyle"
android:gravity="right">
android:gravity="end">

<com.google.android.material.button.MaterialButton
android:id="@+id/ButtonClip"
Expand Down
8 changes: 4 additions & 4 deletions app/src/main/res/layout/gameslist_controls.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip"
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip"
android:minLines="2"
android:accessibilityLiveRegion="none" />

Expand All @@ -113,8 +113,8 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginTop="8dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip"
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip"
android:minLines="2"
android:accessibilityLiveRegion="none" />
</LinearLayout>
6 changes: 3 additions & 3 deletions app/src/main/res/layout/gameslist_filters.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_weight="1"
android:layout_marginRight="8dip"
android:layout_marginEnd="8dip"
android:hint="Order by" />

<jwtc.android.chess.views.FixedDropdownView
Expand All @@ -155,13 +155,13 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:orientation="horizontal"
android:layout_gravity="right">
android:layout_gravity="end">

<TextView
android:id="@+id/TextViewFilterInfo"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_marginRight="16dip"
android:layout_marginEnd="16dip"
android:text="0" />

<com.google.android.material.button.MaterialButton
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/hotspotboard_board_bottom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
android:src="@drawable/turnempty"
android:layout_height="12dip"
android:layout_width="12dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<TextView
android:id="@+id/TextPlayer"
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/hotspotboard_board_top.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
android:src="@drawable/turnempty"
android:layout_height="12dip"
android:layout_width="12dip"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip" />
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip" />

<TextView
android:id="@+id/TextOpponent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/hotspotboard_controls.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
android:id="@+id/ButtonDraw"
android:text="@string/hotspot_draw"
android:layout_width="wrap_content"
android:layout_marginLeft="16dp"
android:layout_marginStart="16dp"
style="@style/ChessButton" />
</LinearLayout>

Expand Down
12 changes: 6 additions & 6 deletions app/src/main/res/layout/ics_board_bottom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
android:id="@+id/ImageBottomTurn"
android:layout_height="wrap_content"
android:layout_width="wrap_content"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip">
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip">

<ImageView
android:src="@drawable/turnblack"
Expand All @@ -34,7 +34,7 @@
android:text="00:00"
android:gravity="center_vertical"
style="@style/MyNormalTextStyle"
android:layout_marginLeft="8dip" />
android:layout_marginStart="8dip" />

<TextView
android:text="@string/ics_playerone"
Expand All @@ -49,7 +49,7 @@
android:layout_height="wrap_content"
android:layout_width="wrap_content"
style="@style/MyHeaderTextStyle"
android:layout_marginLeft="3dip" />
android:layout_marginStart="3dip" />

<TextView
android:id="@+id/TextViewMoveNumber"
Expand All @@ -58,7 +58,7 @@
android:gravity="right|center_vertical"
android:layout_width="wrap_content"
android:layout_height="20dp"
android:layout_marginRight="5dp" />
android:layout_marginEnd="5dp" />

<TextView
android:id="@+id/TextViewICSTimePerMove"
Expand All @@ -67,7 +67,7 @@
android:gravity="center_vertical"
android:layout_width="wrap_content"
android:layout_height="20dp"
android:layout_marginRight="5dp"
android:layout_marginEnd="5dp"
android:visibility="gone" />

<TextView
Expand Down
10 changes: 5 additions & 5 deletions app/src/main/res/layout/ics_board_top.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
android:id="@+id/ImageTopTurn"
android:layout_height="wrap_content"
android:layout_width="wrap_content"
android:layout_marginLeft="8dip"
android:layout_marginRight="8dip">
android:layout_marginStart="8dip"
android:layout_marginEnd="8dip">

<ImageView
android:src="@drawable/turnblack"
Expand All @@ -34,7 +34,7 @@
android:text="00:00"
android:gravity="center_vertical"
style="@style/MyNormalTextStyle"
android:layout_marginLeft="8dip" />
android:layout_marginStart="8dip" />

<TextView
android:text="@string/ics_playertwo"
Expand All @@ -49,14 +49,14 @@
android:layout_height="wrap_content"
android:layout_width="wrap_content"
style="@style/MyHeaderTextStyle"
android:layout_marginLeft="3dip" />
android:layout_marginStart="3dip" />

<TextView
android:id="@+id/TextViewICSBoardNum"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="# 0"
android:layout_marginRight="5dp"
android:layout_marginEnd="5dp"
style="@style/MyHeaderTextStyle"
android:gravity="right|center_vertical" />
</TableRow>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/ics_client.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
android:layout_alignParentBottom="true"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:paddingLeft="4dip"
android:paddingStart="4dip"
android:stretchColumns="1">

<TableRow>
Expand Down
8 changes: 4 additions & 4 deletions app/src/main/res/layout/ics_game_row.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

<TableRow
android:paddingTop="4dip"
android:paddingLeft="4dip"
android:paddingRight="4dip">
android:paddingStart="4dip"
android:paddingEnd="4dip">

<TextView
android:id="@+id/nr"
Expand Down Expand Up @@ -49,8 +49,8 @@
<TableRow
android:paddingTop="4dip"
android:paddingBottom="4dip"
android:paddingLeft="4dip"
android:paddingRight="4dip">
android:paddingStart="4dip"
android:paddingEnd="4dip">

<TextView
android:id="@+id/text_type"
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/ics_login.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,15 @@
android:id="@+id/ButICSRegister"
android:layout_width="0dip"
android:layout_weight="1"
android:layout_marginRight="2dip"
android:layout_marginEnd="2dip"
style="@style/ChessButton" />

<com.google.android.material.button.MaterialButton
android:text="@string/button_login"
android:id="@+id/ButICSLogin"
android:layout_width="0dip"
android:layout_weight="1"
android:layout_marginLeft="2dip"
android:layout_marginStart="2dip"
style="@style/ChessButton" />
</TableRow>
</TableLayout>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/ics_match.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
android:text="@string/ics_seekseek"
style="@style/MyHeaderTextStyle"
android:id="@+id/RadioButtonSeek"
android:paddingRight="30dp" />
android:paddingEnd="30dp" />

<RadioButton
android:text="@string/ics_seekchallenge"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/layout/ics_play_controls.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
android:id="@+id/ButtonICSExamineRevert"
app:icon="@drawable/ic_backspace"
style="@style/ChessImageButton"
android:layout_marginRight="30dp" />
android:layout_marginEnd="30dp" />
</LinearLayout>

<LinearLayout
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/ics_player_row.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
android:layout_width="50dp"
android:layout_margin="2dp"
android:layout_alignParentTop="true"
android:layout_alignParentLeft="true"
android:layout_alignParentStart="true"
android:text="rating"
android:padding="2dp"
android:layout_height="wrap_content" />
Expand All @@ -19,7 +19,7 @@
android:textSize="16sp"
android:layout_width="wrap_content"
android:layout_margin="2dp"
android:layout_toRightOf="@+id/text_rating"
android:layout_toEndOf="@+id/text_rating"
android:layout_alignParentTop="true"
android:text="name"
android:padding="2dp"
Expand Down
Loading