Conversation
Collaborator
Author
|
This breaks backward compatibility. If this is acceptable, we need to double check our unit tests and fix the non-FUELCompat tests that uses Gaussian random numbers. |
ctpeterson
pushed a commit
to ctpeterson/qex
that referenced
this pull request
Jan 12, 2023
…ng: avoid extreme values in gaussian jcosborn#8" commit in main branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make the uniform random number for the log function in the Box-Muller algorithm always non-zero. For RngMilc6, rescale the value from uniform and remove the use of TINY. For MRG32k3a, remove the use of TINY since the uniform already excludes zero and one.