Symfony 4, PHP 7.2+ and PHPUnit 5 compatibility, PSR-4 autoloading#3
Open
MisatoTremor wants to merge 3 commits intojdewit:masterfrom
Open
Symfony 4, PHP 7.2+ and PHPUnit 5 compatibility, PSR-4 autoloading#3MisatoTremor wants to merge 3 commits intojdewit:masterfrom
MisatoTremor wants to merge 3 commits intojdewit:masterfrom
Conversation
MisatoTremor
force-pushed
the
symfony_3.0
branch
4 times, most recently
from
61c63b1 to
c1a0aca
Compare
MisatoTremor
changed the title
MisatoTremor
force-pushed
the
symfony_3.0
branch
from
c1a0aca to
214a5e6
Compare
Contributor
Author
|
Updated & rebased |
MisatoTremor
force-pushed
the
symfony_3.0
branch
from
214a5e6 to
ca01a8d
Compare
Contributor
Author
|
Updated (compatibility for PHP 7.2+) & rebased |
MisatoTremor
force-pushed
the
symfony_3.0
branch
2 times, most recently
from
1605cdf to
1412f28
Compare
MisatoTremor
force-pushed
the
symfony_3.0
branch
from
1412f28 to
b5f8107
Compare
* Fix/Add Symfony components * Fix deprecations under Symfony 4.2 * Use autowiring * Update README * Add UPGRADE
MisatoTremor
force-pushed
the
symfony_3.0
branch
from
53d6fd4 to
73bbd29
Compare
MisatoTremor
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #2.
It changes the autoloading to PSR-4 like Symfony did. Please consider merging it and tagging a release - maybe 0.2 as #2 contains a semi-BC-break if someone still uses a Twig version < 1.12.