Skip to content

fix(release): replace secrets-in-if with env-bridge guard step #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdfalk merged 1 commit into from
Apr 29, 2026
Merged

fix(release): replace secrets-in-if with env-bridge guard step #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/reusable-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,23 @@ jobs:
# commits touch .github/workflows/ — the default GITHUB_TOKEN
# can't. Skipped entirely when CI_APP_ID isn't configured so the
# job doesn't emit a noisy error; falls back to GITHUB_TOKEN.
# `if:` cannot reference secrets.* directly in a workflow_call workflow
# ("Unrecognized named-value: 'secrets'"). Materialize CI_APP_ID through
# env in a guard step, then gate the mint step on that step's output.
- name: Check for App credentials
id: check-app
env:
CI_APP_ID: ${{ secrets.CI_APP_ID }}
run: |
if [ -n "$CI_APP_ID" ]; then
echo "have-app=true" >> "$GITHUB_OUTPUT"
else
echo "have-app=false" >> "$GITHUB_OUTPUT"
fi

- name: Mint App token for tag push
id: app-token
if: ${{ secrets.CI_APP_ID != '' }}
if: steps.check-app.outputs.have-app == 'true'
uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
with:
app-id: ${{ secrets.CI_APP_ID }}
Expand Down
Loading