This repository was archived by the owner on Dec 25, 2024. It is now read-only.
General code cleanup #205
Draft
General code cleanup #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeaye
reviewed
Aug 25, 2021
|
|
||
| pub type PANEL = ll::PANEL; | ||
|
|
||
| #[cfg(feature="panel")] |
Owner
There was a problem hiding this comment.
Why can we remove all of these, if we needed them before?
Collaborator
Author
There was a problem hiding this comment.
Because i'm replacing them with much fewer #[cfg(feature="panel")] lines in lib.rs.
jeaye
reviewed
Aug 25, 2021
| #define PCONSTU(ty, NAME) printf("pub const " #NAME ": " #ty " = %llu;\n", (unsigned long long) (NAME)) | ||
|
|
||
| int main() { | ||
| /* some values aren't set until after this is run */ |
Collaborator
Author
There was a problem hiding this comment.
This was not needed in my previous pr; I forgot to remove it. ACS values are initialized later but they are now defined as functions.
jeaye
reviewed
Aug 25, 2021
|
|
||
|
|
||
| #[link_name="box"] pub fn box_(w: WINDOW, v: chtype, h: chtype) -> i32 | ||
| pub fn box_(w: WINDOW, v: chtype, h: chtype) -> i32 |
Collaborator
Author
There was a problem hiding this comment.
I don't see why it was needed in the first place.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.