[iOS] Hide elements in ItemView & PosterButton from voiceover#1740
Open
samglt wants to merge 2 commits intojellyfin:mainfrom
Open
[iOS] Hide elements in ItemView & PosterButton from voiceover#1740samglt wants to merge 2 commits intojellyfin:mainfrom
samglt wants to merge 2 commits intojellyfin:mainfrom
Conversation
JPKribs
added
bug
LePips
requested changes
Sep 28, 2025
| .backport | ||
| .matchedTransitionSource(id: "item", in: namespace) | ||
| .posterShadow() | ||
| .accessibilityElement(children: .ignore) |
Member
There was a problem hiding this comment.
We're gonna have to think more about how to properly set PosterButton, as there are a variety of states we have to consider where this direct ignore may not be correct.
- when
Show poster labelsis disabled, the title text is hidden from the label. Instead, an abbreviated title is shown on the poster in the placeholder/failure state. - overlay elements like watched, progress, and favorited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1737
This hides the backdrop image in item views from VO, gives the logo images accessibility labels, and disables OCR on poster images.
For some reason the logo images sometimes still got their text read out even though I tried ignoring their contents with accessibilityElement(), so I've hidden them since the navigation title already contains the item's title anyway.
Demo:
less.repetition.mov