Skip to content

TV Shows watching indicators#1769

Open
hqueiroga wants to merge 7 commits intojellyfin:mainfrom
hqueiroga:tvshows-watched-indicators
Open

TV Shows watching indicators#1769
hqueiroga wants to merge 7 commits intojellyfin:mainfrom
hqueiroga:tvshows-watched-indicators

Conversation

@hqueiroga
Copy link
Contributor

@hqueiroga hqueiroga commented Oct 20, 2025

Added Watched / Unwatched Indicators for TV shows, keeping consistency with the Library screen.

Simulator Screenshot - Apple TV 4K (3rd generation) (at 1080p) - 2025-10-20 at 10 47 34 Simulator Screenshot - iPhone 17 Pro - 2025-10-20 at 19 59 04 Simulator Screenshot - iPhone 17 Pro - 2025-10-20 at 19 59 14

@hqueiroga hqueiroga marked this pull request as ready for review October 20, 2025 17:29
@JPKribs
Copy link
Member

JPKribs commented Oct 20, 2025

I like how this looks and give us some more color coming from the accent. IMO, reusing the watched indicator is smart and I'm in favor of this change! Can we ensure we're doing the same thing for iOS so we have consistency between platforms?

I haven't had a chance to check, but does this take the setting for watch indicator into account as well? I don't believe we'd need/want that but I wanted to check if toggling these on/off is expected behavior.

I'll defer to @LePips whether the unplayed indicator makes sense on the episode picker.

@JPKribs JPKribs added enhancement New feature or request tvOS Impacts tvOS labels Oct 20, 2025
@hqueiroga
Copy link
Contributor Author

@JPKribs I have updated the PR with the iOS change. Kept same style from the Library screen :)

Copy link
Member

@JPKribs JPKribs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! Just an item to make sure this will continue working well for us moving forward so it's not purely locked to .jellyfinPurple. Something I am wrestling with is the unplayed indicator.

I feel like, if we add it, we should use the indicate setting to determine if the user wants it on or off:

@Default(.Customization.Indicators.showUnplayed)
private var showUnplayed

But if we do that, we might as well also use these as well to allow folks to turn off the other overlay elements as well:

@Default(.Customization.Indicators.showProgress)
private var showProgress
@Default(.Customization.Indicators.showPlayed)
private var showPlayed

Which isn't an issue but then there is that split of whether we want to separate library vs item indicators since maybe I'd want the indicators on the library as a whole vs not on the item or vice versa?

Regardless, I think those are the only changes I can think of and I'll let @LePips be the verdict on the unwatched indicators. I'm leaning towards having those toggle with the library indicator settings but the played and progress are both untoggleable since those seem more important in this view while the unwatched is more superficial.

Copy link
Contributor Author

@hqueiroga hqueiroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done!

@hqueiroga hqueiroga requested a review from JPKribs October 27, 2025 07:58
Copy link
Member

@JPKribs JPKribs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working through the revisions. @LePips will have final word before the merge in case I am missing something but this looks good from my end!

Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, but I do change indicators and the poster over in #1752 but incidentally don't make the change to have episodes use the same indicator - so you would still be able to contribute the change after that work is done.

However, something I'll have to think about is whether to show the unwatched indicator on episodes. I currently define the indicators to be contextually used with posters during general media navigation, not necessarily episode backdrops when viewing episode lists.

@hqueiroga
Copy link
Contributor Author

Thanks @LePips for your feedback :)
Think the watched episode indicator is nice to have, as you may see what you have already watched on the show... but unwatched one, it's not that important... let you to judge what's the best :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tvOS Impacts tvOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants