Conversation
|
I like how this looks and give us some more color coming from the accent. IMO, reusing the watched indicator is smart and I'm in favor of this change! Can we ensure we're doing the same thing for iOS so we have consistency between platforms? I haven't had a chance to check, but does this take the setting for watch indicator into account as well? I don't believe we'd need/want that but I wanted to check if toggling these on/off is expected behavior. I'll defer to @LePips whether the unplayed indicator makes sense on the episode picker. |
|
@JPKribs I have updated the PR with the iOS change. Kept same style from the Library screen :) |
JPKribs
left a comment
There was a problem hiding this comment.
I think this looks good! Just an item to make sure this will continue working well for us moving forward so it's not purely locked to .jellyfinPurple. Something I am wrestling with is the unplayed indicator.
I feel like, if we add it, we should use the indicate setting to determine if the user wants it on or off:
@Default(.Customization.Indicators.showUnplayed)
private var showUnplayed
But if we do that, we might as well also use these as well to allow folks to turn off the other overlay elements as well:
@Default(.Customization.Indicators.showProgress)
private var showProgress
@Default(.Customization.Indicators.showPlayed)
private var showPlayed
Which isn't an issue but then there is that split of whether we want to separate library vs item indicators since maybe I'd want the indicators on the library as a whole vs not on the item or vice versa?
Regardless, I think those are the only changes I can think of and I'll let @LePips be the verdict on the unwatched indicators. I'm leaning towards having those toggle with the library indicator settings but the played and progress are both untoggleable since those seem more important in this view while the unwatched is more superficial.
Swiftfin tvOS/Views/ItemView/Components/EpisodeSelector/Components/EpisodeCard.swift
Outdated
Show resolved
Hide resolved
Swiftfin tvOS/Views/ItemView/Components/EpisodeSelector/Components/EpisodeCard.swift
Outdated
Show resolved
Hide resolved
Swiftfin/Views/ItemView/Components/EpisodeSelector/Components/EpisodeCard.swift
Outdated
Show resolved
Hide resolved
LePips
left a comment
There was a problem hiding this comment.
Apologies, but I do change indicators and the poster over in #1752 but incidentally don't make the change to have episodes use the same indicator - so you would still be able to contribute the change after that work is done.
However, something I'll have to think about is whether to show the unwatched indicator on episodes. I currently define the indicators to be contextually used with posters during general media navigation, not necessarily episode backdrops when viewing episode lists.
|
Thanks @LePips for your feedback :) |
Added Watched / Unwatched Indicators for TV shows, keeping consistency with the Library screen.