Open
Conversation
- tvOS Basic Stepper - tvOS Form ButtonStyle - Picker Overload for CaseIterable - Chevron Alert Button Spacing
JPKribs
added
developer
JPKribs
changed the title
CustomizationSettingsView & IndicatorSettingsViewCustomizationSettingsView
- tvOS Basic Stepper - tvOS Form ButtonStyle - Picker Overload for CaseIterable - Chevron Alert Button Spacing
JPKribs
force-pushed
the
customizeSettings
branch
from
c01a662 to
d3322de
Compare
… into customizeSettings
Member
Author
|
Should be good to go. I think there is a better way to abstract This should be compatible with the changes in #1870 as I am pulling policy checks from the user and not from our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #1222
Consolidates all Customization settings into a single view for both iOS and tvOS. Also reorganizes the settings.
Customization is now in Customization -> Advanced instead of Accessibility -> Customize.
Removed all the sections that were their own files. I thought this made them cleaner and easier to use but the reality is this just meant searching more files to find things and often meant a lot of re-declarations that wasn't necessary. This is our largest single settings view and it's only 336 lines so I don't think this warrants the level of splitting I was doing prior and I never reuse the sections anyway so I think a single file is the most efficient and best way of doing this.
Settings are now ordered based on kind of the order you see this. Open to other suggestions but my thinking is:
homeSettings(First thing you see)mediaSettings(First think you see in the media tab before going into a library)filterSettings(First think you see in a library at the top)librarySettings(Library settings as a whole)posterSettings(Poster settings as a component of the library)itemSettings(Item setting under the poster)itemViewSettings(Item view when selecting the poster)itemManagementSettings(Item management in the Item View)Also migrates over the
IndicatorViewas that was 4 settings and a small add-on. I set this up for where we can add the poster for tvOS indicators to show as well. Left as a TODO for now.Videos
Simulator.Screen.Recording.-.Apple.TV.-.2026-02-22.at.21.25.00.mov
Simulator.Screen.Recording.-.iPhone.-.2026-02-22.at.21.16.51.mov