Default Track Settings & Unify VideoPlayerSettingsView#1888
Draft
JPKribs wants to merge 14 commits intojellyfin:mainfrom
Draft
Default Track Settings & Unify VideoPlayerSettingsView#1888JPKribs wants to merge 14 commits intojellyfin:mainfrom
VideoPlayerSettingsView#1888JPKribs wants to merge 14 commits intojellyfin:mainfrom
Conversation
VideoPlayerSettingsView
…line servers don't provide CulturePicker. They likely also don't provide Country or other Localizations either but Culture is what I have for this PR.
Member
Author
|
This PR is done but there is a lot of localizing. I also touch this same place via other outstanding PRs. When those are closed, I will finish up the localization and finalize this one. Videos are up-to-daet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #1068
Because of how #1581 configured it, we are already pulling the default track selection based on the
UserDto.UserConfigurationsettings that we get from the server. This PR just adds a new setting to update these values from Swiftfin instead of relying on folks changing this from Jellyfin-Web:Settings > Playback > Audio Settings

Settings > Subtitles > Subtitles

This PR also fully refactors
VideoPlayerSettingsViewto be platform agnostic.This PR also migrates
ServerUserAdminViewModelto stateful and cleans up the views that use this. Most of these are a straight change but some of these there was some additional cleanup. The 3 big cleanups were reducing the comments that I originally put in there, combiningvars when they were needlessly split up (by me), and finally, removing duplicate deletion logic.TODO
Videos
Swiftfin to Web Sync
Screen.Recording.2026-03-01.at.12.31.53.mov
tvOS
Simulator.Screen.Recording.-.Apple.TV.-.2026-02-27.at.17.18.25.mov
iOS
Simulator.Screen.Recording.-.iPhone.-.2026-02-27.at.17.22.16.mov