Skip to content

Default Track Settings & Unify VideoPlayerSettingsView#1888

Draft
JPKribs wants to merge 14 commits intojellyfin:mainfrom
JPKribs:userCustomizations
Draft

Default Track Settings & Unify VideoPlayerSettingsView#1888
JPKribs wants to merge 14 commits intojellyfin:mainfrom
JPKribs:userCustomizations

Conversation

@JPKribs
Copy link
Member

@JPKribs JPKribs commented Jan 2, 2026

Summary

Resolves: #1068

Because of how #1581 configured it, we are already pulling the default track selection based on the UserDto.UserConfiguration settings that we get from the server. This PR just adds a new setting to update these values from Swiftfin instead of relying on folks changing this from Jellyfin-Web:

Settings > Playback > Audio Settings
Image

Settings > Subtitles > Subtitles
Image

This PR also fully refactors VideoPlayerSettingsView to be platform agnostic.

This PR also migrates ServerUserAdminViewModel to stateful and cleans up the views that use this. Most of these are a straight change but some of these there was some additional cleanup. The 3 big cleanups were reducing the comments that I originally put in there, combining vars when they were needlessly split up (by me), and finally, removing duplicate deletion logic.

TODO

  • Localize strings
  • Wait on some other PRs that touch these views to avoid merging conflicts

Videos

Swiftfin to Web Sync
Screen.Recording.2026-03-01.at.12.31.53.mov
tvOS
Simulator.Screen.Recording.-.Apple.TV.-.2026-02-27.at.17.18.25.mov
iOS
Simulator.Screen.Recording.-.iPhone.-.2026-02-27.at.17.22.16.mov

@JPKribs JPKribs added enhancement New feature or request iOS Impacts iOS or iPadOS tvOS Impacts tvOS labels Jan 2, 2026
@JPKribs JPKribs changed the title Default Audio / Subtitle Settings Default Track Settings & Unify VideoPlayerSettingsView Feb 28, 2026
@JPKribs
Copy link
Member Author

JPKribs commented Mar 2, 2026

This PR is done but there is a lot of localizing. I also touch this same place via other outstanding PRs. When those are closed, I will finish up the localization and finalize this one. Videos are up-to-daet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request iOS Impacts iOS or iPadOS tvOS Impacts tvOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to set default audio/subtitle tracks

1 participant