Open
Conversation
JPKribs
added
enhancement
JPKribs
reviewed
Mar 4, 2026
Member
JPKribs
left a comment
JPKribs
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This looks good to me and works in testing. Small potential change I'm frankly not sure of myself so I'll let Ethan make the final verdict for this
Comment on lines
+126
to
+130
| var rate: Float = Defaults[.VideoPlayer.Playback.playbackRate] { | ||
| didSet { | ||
| Defaults[.VideoPlayer.Playback.playbackRate] = rate | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Since we're setting this at the Default I think we can just use:
@Default(.videoPlayer.Playback.playbackRate)
private var rateBut then we'd have to update all of the locations that call this from the published rate to do the same...
I'll defer to @LePips for this. Your solution works so I'll lean on them for whether or not it makes more sense to call this from the Default when we need it or keep the published rate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
playbackRateto swiftfin defaults and write to it whenever there's a change to playback rate. Also added to vlc configurator when that's created to actually persist the playback rate.Thif fixes #711