Open
Conversation
Member
Author
|
So, for the time being, this is slightly more code than before but when also using these to replace their variants in the This also replaces the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a 2 parter to help with #1921.
PublicUserRowButtonis just aChevronButton. We can (and UnifySelectUserView#1921 does) use the sameChevronButtonfor theSelectUserViewbut this it's cleaner to just update it here.UserGridButtonis almost identical for thePublicUserGridButtonand theSelectUserView.UserGridButton. This aims to create a single, shared button that we can re-use for both views. For now, this is only used in theUserSignInViewbut my goal in UnifySelectUserView#1921 is to use this there as well for the grid but I want to split this off to make this cleaner.The end result is functionally no different for now but this should make this easier to maintain and, for the grid buttons, offer better re-usabe for when I finish up the
SelectUserViewScreenshots
List:

Grid:
Unfocused:

Focused:
