Fix Discord Username#281
Closed
chiragkrishna wants to merge 5 commits intojellyfin:masterfrom
chiragkrishna:Discord-Username
Closed
Fix Discord Username#281chiragkrishna wants to merge 5 commits intojellyfin:masterfrom chiragkrishna:Discord-Username
chiragkrishna wants to merge 5 commits intojellyfin:masterfrom
chiragkrishna:Discord-Username
Conversation
Contributor
Author
|
it is working as expected. may i know what is broken? |
Member
|
It's a breaking change, meaning that everyone with a discord connection configured will need to reconfigure. |
Contributor
Author
|
no it doesn't change the default behaviour. BotUsername - Username of discord bot |
Shadowghost
approved these changes
Sep 8, 2024
Member
|
It is breaking in the case of |
Contributor
Author
|
I don't understand how this PR will break Item added?? |
Contributor
Author
|
this PR: #248 basically achieves the same thing. or am I missing something here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #276