Create an all-in-one handlebars file for Discord#336
Open
Kneckter wants to merge 2 commits intojellyfin:masterfrom
Open
Create an all-in-one handlebars file for Discord#336Kneckter wants to merge 2 commits intojellyfin:masterfrom
Kneckter wants to merge 2 commits intojellyfin:masterfrom
Conversation
Updated URLs in Discord template to include a leading slash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds a new handlebar file to the Discord templates that gives a template for each
NotificationType. I was able to test the following:I was not able to trigger these to confirm their formatting:
This kind of setup could also be applied to other notification providers since the
if_equalshelper is available to all of them.