fix: trim whitespace from SMTP server address before connecting#381
Open
nikolainyegaard wants to merge 1 commit intojellyfin:masterfrom
Open
fix: trim whitespace from SMTP server address before connecting#381nikolainyegaard wants to merge 1 commit intojellyfin:masterfrom
nikolainyegaard wants to merge 1 commit intojellyfin:masterfrom
Conversation
Users copying a hostname from a browser or config file may inadvertently include a leading or trailing space. ConnectAsync treats the raw string literally, causing a DNS lookup failure with no obvious error message. Calling .Trim() on SmtpServer before passing it to ConnectAsync prevents this silent failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user pastes an SMTP server hostname that has a trailing or leading space (easy to do when copying from a browser), ConnectAsync fails with a DNS error. This one-line fix calls .Trim() on the server address before the connection is made.